Yifeng-Wang commented on code in PR #9107:
URL: https://github.com/apache/incubator-gluten/pull/9107#discussion_r2011195805
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala:
##########
@@ -109,6 +109,66 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
}
}
+ private def replaceStaticInvokeWithExpressionTransformer(
+ i: StaticInvoke,
+ attributeSeq: Seq[Attribute],
+ expressionsMap: Map[Class[_], String]): ExpressionTransformer = {
+ val objectName = i.staticObject.getName.stripSuffix("$")
+
+ if (objectName.endsWith("UrlCodec")) {
Review Comment:
@jinchengchenghh using astaticInvokeMap in the latest fix:
- a staticInvokeMap to define the supported objects and their functions and
for future additions.
- special handling for UrlCodec which only uses the 1st argument
Could you please review the refactor and let me know if further adjustment
is needed. thks
##########
gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala:
##########
@@ -109,6 +109,66 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
}
}
+ private def replaceStaticInvokeWithExpressionTransformer(
+ i: StaticInvoke,
+ attributeSeq: Seq[Attribute],
+ expressionsMap: Map[Class[_], String]): ExpressionTransformer = {
+ val objectName = i.staticObject.getName.stripSuffix("$")
+
+ if (objectName.endsWith("UrlCodec")) {
Review Comment:
@jinchengchenghh using a staticInvokeMap in the latest fix:
- a staticInvokeMap to define the supported objects and their functions and
for future additions.
- special handling for UrlCodec which only uses the 1st argument
Could you please review the refactor and let me know if further adjustment
is needed. thks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
