Copilot commented on code in PR #11712: URL: https://github.com/apache/gluten/pull/11712#discussion_r3389720481
########## ep/build-velox/src/get-velox.sh: ########## @@ -17,8 +17,8 @@ set -exu CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) -VELOX_REPO=https://github.com/IBM/velox.git -VELOX_BRANCH=dft-2026_06_06 +VELOX_REPO=https://github.com/zhouyuan/velox.git +VELOX_BRANCH=dft-2026_06_06-fbthrift Review Comment: Defaulting VELOX_REPO to a personal fork (zhouyuan/velox) and a custom branch makes the build non-reproducible and fragile (fork/branch can be rebased or deleted) and also conflicts with the documented assumption that Gluten tracks the IBM Velox fork (docs/get-started/Velox.md). It’s also internally inconsistent with VELOX_ENHANCED_BRANCH=ibm-2026_06_06 (enhanced builds will still use the non-IBM repo unless the user overrides --velox_repo). Please restore the default to the project’s maintained Velox fork and keep custom forks/branches as opt-in via --velox_repo/--velox_branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
