Copilot commented on code in PR #11712: URL: https://github.com/apache/gluten/pull/11712#discussion_r3390803000
########## ep/build-velox/src/get-velox.sh: ########## @@ -17,8 +17,8 @@ set -exu CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) -VELOX_REPO=https://github.com/IBM/velox.git -VELOX_BRANCH=dft-2026_06_06 +VELOX_REPO=https://github.com/zhouyuan/velox.git +VELOX_BRANCH=dft-2026_06_06-fbthrift Review Comment: The default Velox source has been changed to a personal fork/branch. This is a supply-chain risk for CI/dev builds and also makes `--enable_enhanced_features=ON` inconsistent: the script will try to resolve `ibm-2026_06_06` from `zhouyuan/velox`, which is unlikely to exist. Keep the default pointing at the project’s documented IBM fork, and rely on `--velox_repo/--velox_branch` flags for ad-hoc forks/branches. ########## dev/vcpkg/vcpkg.json: ########## @@ -24,6 +24,8 @@ "name": "folly", "features": ["zstd", "lz4", "lzma", "snappy"] }, + "fizz", + "fbthrift", Review Comment: This entry uses a tab/odd indentation (visible before "fizz"), which makes the JSON formatting inconsistent and can create noisy diffs or formatting/lint issues. Align indentation with the rest of the manifest (spaces). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
