Copilot commented on code in PR #11712: URL: https://github.com/apache/gluten/pull/11712#discussion_r3396656755
########## ep/build-velox/src/get-velox.sh: ########## @@ -17,8 +17,8 @@ set -exu CURRENT_DIR=$(cd "$(dirname "$BASH_SOURCE")"; pwd) -VELOX_REPO=https://github.com/IBM/velox.git -VELOX_BRANCH=dft-2026_06_06 +VELOX_REPO=https://github.com/zhouyuan/velox.git +VELOX_BRANCH=dft-2026_06_06-fbthrift Review Comment: The default Velox repository/branch is switched to a personal fork. This makes builds depend on a non-canonical remote that may disappear or diverge from the intended upstream, and it’s hard to audit in CI. Prefer keeping the default pointed at the project’s chosen upstream (and use the existing --velox_repo/--velox_branch flags for testing forks). ########## dev/vcpkg/init.sh: ########## @@ -70,7 +70,7 @@ cd "$SCRIPT_ROOT" if [ ! -d "$VCPKG_ROOT" ] || [ -z "$(ls "$VCPKG_ROOT")" ]; then # The builtin-baseline (commit hash) specified in vcpkg.json should exist in this branch. # Therefore, upgrading the builtin-baseline may require updating the branch. - git clone https://github.com/microsoft/vcpkg.git --branch 2025.09.17 "$VCPKG_ROOT" + git clone https://github.com/microsoft/vcpkg.git --branch 2026.03.18 "$VCPKG_ROOT" fi Review Comment: The vcpkg bootstrap branch/tag is updated to 2026.03.18, but dev/vcpkg/README.md still states the builtin-baseline corresponds to the 2025.09.17 tag. This leaves the documentation inconsistent with the script and can mislead contributors who follow the manual setup instructions. ########## dev/vcpkg/vcpkg.json: ########## @@ -24,6 +24,8 @@ "name": "folly", "features": ["zstd", "lz4", "lzma", "snappy"] }, + "fizz", + "fbthrift", "boost-atomic", Review Comment: There is a stray tab indentation before "fizz". While JSON allows tabs, this repo’s JSON files are otherwise space-indented; keeping consistent formatting avoids noisy diffs and reduces the chance of editor/formatter churn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
