Copilot commented on code in PR #11712: URL: https://github.com/apache/gluten/pull/11712#discussion_r3396656719
########## dev/ci-velox-buildstatic-centos-7.sh: ########## @@ -17,6 +17,6 @@ set -e -export NUM_THREADS=4 +cp ep/build-velox/src/socket.h /usr/include/asm-generic/socket.h Review Comment: This script now overwrites a system header in /usr/include. Mutating system include files makes the build non-reproducible, can break other packages in the image, and will fail when the script is run without root privileges. Prefer failing fast with an actionable message (or installing the proper kernel/glibc headers in the image) rather than replacing /usr/include/asm-generic/socket.h from the repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
