yuqi1129 commented on code in PR #4167:
URL: https://github.com/apache/gravitino/pull/4167#discussion_r1683859247
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/metadata/GravitinoCatalog.java:
##########
@@ -116,4 +128,16 @@ public static String toJson(GravitinoCatalog catalog)
throws JsonProcessingExcep
public static GravitinoCatalog fromJson(String jsonString) throws
JsonProcessingException {
return objectMapper.readValue(jsonString, GravitinoCatalog.class);
}
+
+ public String getCluster() {
+ return properties.getOrDefault("cluster", "");
+ }
+
+ public boolean isLocally(String cluster) {
Review Comment:
Locally is an adverb word, maybe you need to change it to `local`
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/jdbc/trino/TrinoClusterConnectorAdapter.java:
##########
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.gravitino.trino.connector.catalog.jdbc.trino;
+
+import static
org.apache.gravitino.trino.connector.GravitinoConnectorPluginManager.CONNECTOR_CLUSTER;
+import static
org.apache.gravitino.trino.connector.GravitinoErrorCode.GRAVITINO_MISSING_CONFIG;
+import static
org.apache.gravitino.trino.connector.catalog.jdbc.JDBCCatalogPropertyConverter.JDBC_CONNECTION_PASSWORD_KEY;
+import static
org.apache.gravitino.trino.connector.catalog.jdbc.JDBCCatalogPropertyConverter.JDBC_CONNECTION_URL_KEY;
+import static
org.apache.gravitino.trino.connector.catalog.jdbc.JDBCCatalogPropertyConverter.JDBC_CONNECTION_USER_KEY;
+
+import io.trino.spi.TrinoException;
+import io.trino.spi.session.PropertyMetadata;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.gravitino.trino.connector.catalog.CatalogConnectorAdapter;
+import
org.apache.gravitino.trino.connector.catalog.CatalogConnectorMetadataAdapter;
+import org.apache.gravitino.trino.connector.catalog.HasPropertyMeta;
+import org.apache.gravitino.trino.connector.metadata.GravitinoCatalog;
+
+/**
+ * Support trino cluster connector. Transforming cluster connector
configuration and components into
+ * Gravitino connector.
+ */
+public class TrinoClusterConnectorAdapter implements CatalogConnectorAdapter {
+
+ public static final String TRINO_CLUSTER_URL_KEY = "cluster.connection-url";
+ public static final String TRINO_CLUSTER_USER_KEY =
"cluster.connection-user";
+ public static final String TRINO_CLUSTER_PASSWORD_KEY =
"cluster.connection-password";
+ public static final String TRINO_CLUSTER_DEFAULT_USER = "admin";
+
+ private final HasPropertyMeta propertyMetadata;
+
+ public TrinoClusterConnectorAdapter() {
+ this.propertyMetadata = new TrinoClusterPropertyMeta();
+ }
+
+ @Override
+ public Map<String, String> buildInternalConnectorConfig(GravitinoCatalog
catalog) {
+ Map<String, String> config = new HashMap<>();
+ String jdbc_url = catalog.getProperty(TRINO_CLUSTER_URL_KEY, "");
Review Comment:
`jdbc_url` is not a preferable Java naming style.
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -69,6 +69,13 @@ public class GravitinoConfig {
"true",
false);
+ private static final ConfigEntry GRAVITINO_CLUSTER =
+ new ConfigEntry(
+ "gravitino.cluster",
+ "The cluster name of the trino, if it's empty, all the catalogs
handled by locally",
Review Comment:
`all the catalogs handled by locally` -> `all catalogs will be handled
locally`
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/metadata/GravitinoCatalog.java:
##########
@@ -116,4 +128,16 @@ public static String toJson(GravitinoCatalog catalog)
throws JsonProcessingExcep
public static GravitinoCatalog fromJson(String jsonString) throws
JsonProcessingException {
return objectMapper.readValue(jsonString, GravitinoCatalog.class);
}
+
+ public String getCluster() {
+ return properties.getOrDefault("cluster", "");
+ }
+
+ public boolean isLocally(String cluster) {
+ // Locally catalog means the gravitino connector has not config the
cluster or
Review Comment:
config -> configured
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
