diqiu50 commented on code in PR #4167:
URL: https://github.com/apache/gravitino/pull/4167#discussion_r1689293538


##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -69,6 +69,13 @@ public class GravitinoConfig {
           "true",
           false);
 
+  private static final ConfigEntry GRAVITINO_CLUSTER =
+      new ConfigEntry(
+          "gravitino.cluster",
+          "The cluster name of the trino, if it's empty, all catalogs will be 
handled locally",

Review Comment:
   We can create a catalog with a cluster information:
   ```
   call gravitino.system.create_catalog(
       'gt_mysql',
       'jdbc-mysql',
       map(
           array['jdbc-url', 'jdbc-user', 'jdbc-password', 'jdbc-driver', 
'cluster', 'cluster.connection-url', 'cluster.connection-user'],
           array['jdbc:mysql://mysql/?useSSL=false', 'trino', 'ds123', 
'com.mysql.cj.jdbc.Driver', 'c2', 'jdbc:trino://trino-remote:8080', 'admin']
       )
   );
   ```
   
   When the gravitino-trino-connector config like:
   ```
   #Thu Jun 13 17:50:55 CST 2024
   connector.name=gravitino
   gravitino.metalake=test
   gravitino.uri=http\://gt01.orb.local\:8090
   trino.catalog.store=etc/catalog
   trino.jdbc.uri=jdbc\:trino\://localhost\:8080
   gravitino.cluster=c2
   ```
   
   If the catalog's cluster name equals then the gravition-trino-connector 's  
cluster configuration. The catalog is handle by local



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to