yuqi1129 commented on code in PR #4167:
URL: https://github.com/apache/gravitino/pull/4167#discussion_r1689027891
##########
integration-test/src/test/java/org/apache/gravitino/integration/test/trino/TrinoQueryTestTool.java:
##########
@@ -47,6 +47,10 @@ public static void main(String[] args) throws Exception {
false,
"Generate the output file for the test set, the default value is
'false'");
+ options.addOption(
+ "test_host",
+ true,
+ "host for test server, if --auto is set to 'all', this option is
ignored");
Review Comment:
`host for test server` is very vague, can you give some examples about the
possible value? besides `host for test server` means the the `type` of server
or `address` of the server?
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/metadata/GravitinoCatalog.java:
##########
@@ -116,4 +128,16 @@ public static String toJson(GravitinoCatalog catalog)
throws JsonProcessingExcep
public static GravitinoCatalog fromJson(String jsonString) throws
JsonProcessingException {
return objectMapper.readValue(jsonString, GravitinoCatalog.class);
}
+
+ public String getCluster() {
+ return properties.getOrDefault("cluster", "");
+ }
+
+ public boolean isLocal(String cluster) {
Review Comment:
isLocalCluster
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/metadata/GravitinoCatalog.java:
##########
@@ -116,4 +128,16 @@ public static String toJson(GravitinoCatalog catalog)
throws JsonProcessingExcep
public static GravitinoCatalog fromJson(String jsonString) throws
JsonProcessingException {
return objectMapper.readValue(jsonString, GravitinoCatalog.class);
}
+
+ public String getCluster() {
+ return properties.getOrDefault("cluster", "");
+ }
+
+ public boolean isLocal(String cluster) {
+ // Locally catalog means the gravitino connector has not configured the
cluster or
Review Comment:
Locally -> local, besides please move this comment to the method description.
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -69,6 +69,13 @@ public class GravitinoConfig {
"true",
false);
+ private static final ConfigEntry GRAVITINO_CLUSTER =
+ new ConfigEntry(
+ "gravitino.cluster",
+ "The cluster name of the trino, if it's empty, all catalogs will be
handled locally",
Review Comment:
Can you provide an example here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
