mchades commented on code in PR #4167:
URL: https://github.com/apache/gravitino/pull/4167#discussion_r1687611250
##########
integration-test/src/test/java/org/apache/gravitino/integration/test/trino/TrinoQueryTestTool.java:
##########
@@ -47,6 +47,10 @@ public static void main(String[] args) throws Exception {
false,
"Generate the output file for the test set, the default value is
'false'");
+ options.addOption(
+ "test_host",
+ true,
+ "host for test server, if --auto is set to 'all', this option is
ignored");
Review Comment:
what's the meaning of `test server`?
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -69,6 +69,13 @@ public class GravitinoConfig {
"true",
false);
+ private static final ConfigEntry GRAVITINO_CLUSTER =
+ new ConfigEntry(
+ "gravitino.cluster",
+ "The cluster name of the trino, if it's empty, all catalogs will be
handled locally",
Review Comment:
It seems strange that `gravitino.cluster` is referred to as `The cluster
name of the trino`.
BTW, Where should the user obtain the cluster name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
