yuqi1129 commented on code in PR #4996:
URL: https://github.com/apache/gravitino/pull/4996#discussion_r1799603877
##########
trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryITBase.java:
##########
@@ -68,14 +68,17 @@ public class TrinoQueryITBase {
protected static final String metalakeName = "test";
protected static GravitinoMetalake metalake;
- private static void setEnv() throws Exception {
+ private static BaseIT baseIT;
+
+ private void setEnv() throws Exception {
+ baseIT = new BaseIT();
Review Comment:
> What is the difference between creating an instance and inheritance
Some tests, for example, `SparkQueryRunner` just use `BaseIT` as a field to
start the `Gravitino` server and run TPCDS query. Others just take it as the
base test class.
> Can we add an abstract modifier to baseIT for uniform usage?
it's beyond the scope of this PR scope and we can do the refacor later with
the help of @FANNG1 @diqiu50 for the Spark and Trino related tests that use
`BaseIT` as the class field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
