diqiu50 commented on code in PR #4996:
URL: https://github.com/apache/gravitino/pull/4996#discussion_r1800401817
##########
trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryITBase.java:
##########
@@ -68,14 +68,17 @@ public class TrinoQueryITBase {
protected static final String metalakeName = "test";
protected static GravitinoMetalake metalake;
- private static void setEnv() throws Exception {
+ private static BaseIT baseIT;
+
+ private void setEnv() throws Exception {
+ baseIT = new BaseIT();
Review Comment:
If refactoring is necessary, I think it would be better to move the logic
for starting the Gravitino server out of BaseIT. In BaseIT, the automatic
starting of the Gravitino server is implemented. Test classes that need to use
the default method to start the Gravitino server should inherit from BaseIT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
