diqiu50 commented on code in PR #4996:
URL: https://github.com/apache/gravitino/pull/4996#discussion_r1800395623
##########
trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryITBase.java:
##########
@@ -68,14 +68,17 @@ public class TrinoQueryITBase {
protected static final String metalakeName = "test";
protected static GravitinoMetalake metalake;
- private static void setEnv() throws Exception {
+ private static BaseIT baseIT;
+
+ private void setEnv() throws Exception {
+ baseIT = new BaseIT();
Review Comment:
BaseIT is actually a utility for starting the Gravitino server and Gravitino
client for TrinoTesters.
In the TrinoQueryIT class, starting the Gravitino server is an option for
running the tests.
Therefore, it is not appropriate for the TrinoQueryIT class to inherit from
BaseIT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
