FANNG1 commented on code in PR #7298:
URL: https://github.com/apache/gravitino/pull/7298#discussion_r2115000595
##########
bundles/aws-bundle/build.gradle.kts:
##########
@@ -41,7 +41,6 @@ tasks.withType(ShadowJar::class.java) {
exclude(dependency("org.slf4j:slf4j-api"))
}
- relocate("com.amazonaws", "org.apache.gravitino.aws.shaded.com.amazonaws")
Review Comment:
Iceberg seems shade the pacakge which are possible introduce conflict like
guava, HTTP client, jackson, etc.
Iceberg was bundle:
https://github.com/apache/iceberg/blob/3469cf30f2d839763813596e3f0c66ed16189c9a/aws-bundle/build.gradle#L59-L61
Iceberg Spark runtime:
https://github.com/apache/iceberg/blob/3469cf30f2d839763813596e3f0c66ed16189c9a/spark/v3.5/build.gradle#L296-L316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
