mchades commented on code in PR #7298:
URL: https://github.com/apache/gravitino/pull/7298#discussion_r2131598876
##########
bundles/aliyun-bundle/build.gradle.kts:
##########
Review Comment:
> For gravitino-{specific-fs}.jar seems no need to shade hadoop dependencies
and specific FS dependencies because there are not included in the jar.
they will be included, for example:
https://github.com/apache/gravitino/blob/efd14f35d7d3e0ed89c5badf214fc276e819b185/bundles/aliyun/build.gradle.kts#L43
https://github.com/apache/gravitino/blob/efd14f35d7d3e0ed89c5badf214fc276e819b185/bundles/aws/build.gradle.kts#L47
> For gravitino-{specific-fs}-bundle.jar, seems no need to shade hadoop
dependencies and spcific FS dependencies too, because there is an assumption
that the environment does have hadoop dependencies and specific FS dependencies
packages.
yes, so what I said is that **need to shade third party dependencies to
avoid potential conflicts**
@FANNG1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
