FANNG1 commented on code in PR #7298:
URL: https://github.com/apache/gravitino/pull/7298#discussion_r2128382393
##########
bundles/aliyun-bundle/build.gradle.kts:
##########
@@ -44,12 +44,19 @@ tasks.withType(ShadowJar::class.java) {
}
// Relocate dependencies to avoid conflicts
- relocate("org.jdom", "org.apache.gravitino.aliyun.shaded.org.jdom")
- relocate("org.apache.commons.lang3",
"org.apache.gravitino.aliyun.shaded.org.apache.commons.lang3")
+ relocate("com.aliyun", "org.apache.gravitino.aliyun.shaded.com.aliyun")
Review Comment:
Any reason to shade aliyun packages? Iceberg doesn't provide Aliyun bundle
jars, so the Gravitino Iceberg REST server, which uses the Gravitino Aliyun
bundle to provide Aliyun packages, may not work with the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
