mchades commented on code in PR #7298:
URL: https://github.com/apache/gravitino/pull/7298#discussion_r2128800282
##########
bundles/aliyun-bundle/build.gradle.kts:
##########
Review Comment:
Here is the shading strategy of this PR:
there are three types of dependencies:
1. **hadoop dependencies**
such as: `implementation(libs.hadoop3.client.api)`,
`implementation(libs.hadoop3.client.runtime)`
2. **spcific FS dependencies**
such as: `implementation(libs.hadoop3.oss)`,
`implementation(libs.aliyun.credentials.sdk)`
3. **third party dependencies**
such as: `implementation(libs.guava)`,
`implementation(libs.commons.lang3)`
4. **jdk dependencies**
such as: `implementation(libs.sun.activation)`, `javax/annotation/`
there are four types of jars delivered by Gravitino:
1. **gravitino-{specific-fs}.jar**
when using this jar, we assume that the environment already has hadoop
dependencies and specific FS dependencies, so we need to shade all
non-gravitino dependencies class in the jar to avoid potential conflicts
2. **gravitino-{specific-fs}-bundle.jar**
when using this jar, we assume that the environment does not have hadoop
dependencies and specific FS dependencies, so we don't need to shade the hadoop
dependencies and specific FS dependencies, but need to shade third party
dependencies to avoid potential conflicts
3. **gravitino-filesystem.jar**
this jar is mainly used for GVFS development, shade nothing
4. **gravitino-filesystem-runtime.jar**
user should use this jar for GVFS runtime, should shade all non-gravitino
dependency class in the jar to avoid potential conflicts
**note:** we never shade the jdk dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
