jerryshao commented on code in PR #7674:
URL: https://github.com/apache/gravitino/pull/7674#discussion_r2203733559
##########
core/src/main/java/org/apache/gravitino/listener/api/event/RegisterAndLinkModelEvent.java:
##########
@@ -58,12 +62,12 @@ public ModelInfo registeredModelInfo() {
}
/**
- * Retrieves the uri of the linked model version.
+ * Retrieves the URIs of the linked model version.
*
- * @return the uri of the linked model version
+ * @return the URIs of the linked model version
*/
- public String uri() {
- return uri;
+ public Map<String, String> uris() {
+ return uris;
Review Comment:
We should keep the compatibility of thIs class, this class is user-facing.
So we should not change this API, we can keep and add a new API, you can refer
to fileset's change.
##########
core/src/main/java/org/apache/gravitino/catalog/ModelNormalizeDispatcher.java:
##########
@@ -125,6 +126,18 @@ public void linkModelVersion(
dispatcher.linkModelVersion(normalizeCaseSensitive(ident), uri, aliases,
comment, properties);
}
+ @Override
+ public String getModelVersionUri(NameIdentifier ident, int version, String
uriName)
+ throws NoSuchModelVersionException, NoSuchModelVersionURINameException {
+ return dispatcher.getModelVersionUri(normalizeCaseSensitive(ident),
version, uriName);
+ }
+
+ @Override
+ public String getModelVersionUri(NameIdentifier ident, String alias, String
uriName)
+ throws NoSuchModelVersionException, NoSuchModelVersionURINameException {
+ return dispatcher.getModelVersionUri(normalizeCaseSensitive(ident), alias,
uriName);
+ }
+
Review Comment:
I think the `getModelVersionUri` can be a client-side call, client can call
`getModelVersion` to get a model version, these two interfaces are just the
wrapper of `getModelVersion`, am I right?
##########
core/src/main/java/org/apache/gravitino/listener/api/info/ModelVersionInfo.java:
##########
@@ -92,12 +92,12 @@ public ModelVersionInfo(
}
/**
- * Returns the URI of the model version.
+ * Returns the URIs of the model version.
*
- * @return the URI of the model version.
+ * @return the URIs of the model version.
*/
- public String uri() {
- return uri;
+ public Map<String, String> uris() {
+ return uris;
Review Comment:
Also for this class, we should keep the compability of this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
