jerryshao commented on code in PR #7674:
URL: https://github.com/apache/gravitino/pull/7674#discussion_r2209167412
##########
core/src/main/java/org/apache/gravitino/catalog/ModelNormalizeDispatcher.java:
##########
@@ -125,6 +126,18 @@ public void linkModelVersion(
dispatcher.linkModelVersion(normalizeCaseSensitive(ident), uri, aliases,
comment, properties);
}
+ @Override
+ public String getModelVersionUri(NameIdentifier ident, int version, String
uriName)
+ throws NoSuchModelVersionException, NoSuchModelVersionURINameException {
+ return dispatcher.getModelVersionUri(normalizeCaseSensitive(ident),
version, uriName);
+ }
+
+ @Override
+ public String getModelVersionUri(NameIdentifier ident, String alias, String
uriName)
+ throws NoSuchModelVersionException, NoSuchModelVersionURINameException {
+ return dispatcher.getModelVersionUri(normalizeCaseSensitive(ident), alias,
uriName);
+ }
+
Review Comment:
As I mentioned, these two methods are just the helper method for
`getModelVersion`, to help users to get URI conveniently. The user can
`getModelVersion` and get URI by name by themselves, or we can provide
client-side helper method to get URI simply, but it is not necessary to have a
new client-server API for this requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
