xiaozcy commented on code in PR #7674:
URL: https://github.com/apache/gravitino/pull/7674#discussion_r2206563473
##########
core/src/main/java/org/apache/gravitino/catalog/ModelNormalizeDispatcher.java:
##########
@@ -125,6 +126,18 @@ public void linkModelVersion(
dispatcher.linkModelVersion(normalizeCaseSensitive(ident), uri, aliases,
comment, properties);
}
+ @Override
+ public String getModelVersionUri(NameIdentifier ident, int version, String
uriName)
+ throws NoSuchModelVersionException, NoSuchModelVersionURINameException {
+ return dispatcher.getModelVersionUri(normalizeCaseSensitive(ident),
version, uriName);
+ }
+
+ @Override
+ public String getModelVersionUri(NameIdentifier ident, String alias, String
uriName)
+ throws NoSuchModelVersionException, NoSuchModelVersionURINameException {
+ return dispatcher.getModelVersionUri(normalizeCaseSensitive(ident), alias,
uriName);
+ }
+
Review Comment:
You mean implement it in the client side, or just let users implement it by
their own?
I think it's best to implement it in the server side, because this
implementation would be universal and doing so will simplify the usage.
Besides, it is also convenient to conduct audits on the server side. If the
implementation does not meet the requirements, users can call `getModelVersion`
and choose the URI by their own.
Could you please tell me your concerns about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
