jerryshao commented on code in PR #7674:
URL: https://github.com/apache/gravitino/pull/7674#discussion_r2209171212
##########
core/src/main/java/org/apache/gravitino/catalog/ModelNormalizeDispatcher.java:
##########
@@ -125,6 +126,18 @@ public void linkModelVersion(
dispatcher.linkModelVersion(normalizeCaseSensitive(ident), uri, aliases,
comment, properties);
}
+ @Override
+ public String getModelVersionUri(NameIdentifier ident, int version, String
uriName)
+ throws NoSuchModelVersionException, NoSuchModelVersionURINameException {
+ return dispatcher.getModelVersionUri(normalizeCaseSensitive(ident),
version, uriName);
+ }
+
+ @Override
+ public String getModelVersionUri(NameIdentifier ident, String alias, String
uriName)
+ throws NoSuchModelVersionException, NoSuchModelVersionURINameException {
+ return dispatcher.getModelVersionUri(normalizeCaseSensitive(ident), alias,
uriName);
+ }
+
Review Comment:
The logic is the same as `getModelVersion` in the server-side, so why do we
need to add lots of similar logic in the server side for these two methods?
These can be achieved in the client-side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
