Re: [PR] [#9490] improvement(core): Include lakehouse-generic catalogs in managed entities for proper drop behavior [gravitino]

Sun, 21 Dec 2025 22:48:46 -0800 


jerqi commented on code in PR #9502:
URL: https://github.com/apache/gravitino/pull/9502#discussion_r2638843989


##########
core/src/main/java/org/apache/gravitino/meta/CatalogEntity.java:
##########
@@ -155,6 +156,12 @@ public CatalogInfo 
toCatalogInfoWithResolvedProps(Map<String, String> resolvedPr
         id, name, type, provider, comment, resolvedProperties, auditInfo, 
namespace);
   }
 
+  @Override
+  public boolean managed() {
+    return type == Catalog.Type.FILESET
+        || (type == Catalog.Type.RELATIONAL && 
provider.equalsIgnoreCase("lakehouse-generic"));

Review Comment:
   Another point is like what you mentioned that, we access the database too 
frequently.
   
![image](https://github.com/user-attachments/assets/170d2747-4438-424d-8ae1-fe1f4d3de5fa)
   Actually, we can get the catalog entity from the wrapper directly. We should 
add an internal interface to get the entity for our catalogs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to