jerryshao commented on code in PR #9502:
URL: https://github.com/apache/gravitino/pull/9502#discussion_r2646663474
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -738,28 +739,24 @@ public boolean dropCatalog(NameIdentifier ident, boolean
force)
metalakeIdent,
LockType.WRITE,
() -> {
- checkMetalake(metalakeIdent, store);
try {
boolean catalogInUse = catalogInUse(store, ident);
if (catalogInUse && !force) {
throw new CatalogInUseException(
"Catalog %s is in use, please disable it first or use force
option", ident);
}
Review Comment:
`catalogInUse` will both check the existence of metalake and catalog, and
throw the `NoSuchMetalakeException` and `NoSuchCatalogException` accordingly.
So the semantics are not changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
