jerqi commented on code in PR #9502:
URL: https://github.com/apache/gravitino/pull/9502#discussion_r2646824288


##########
catalogs/catalog-fileset/src/main/java/org/apache/gravitino/catalog/fileset/FilesetCatalogCapability.java:
##########
@@ -25,7 +25,8 @@
 public class FilesetCatalogCapability implements Capability {
   @Override
   public CapabilityResult managedStorage(Scope scope) {
-    if (Objects.requireNonNull(scope) == Scope.SCHEMA) {
+    if (Objects.requireNonNull(scope) == Scope.CATALOG

Review Comment:
   > It is a legacy problem. We can add `FILESET` support here, but there's no 
code leverage this scope currently.
   
   Notice that `Fileset` has the property `managed`. Are they the same concept? 
   What's relation between `ManagedStorage` and fileset properties `managed`? 
Will they conflicted? How to resolve them if conflicted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to