roryqi commented on code in PR #10895:
URL: https://github.com/apache/gravitino/pull/10895#discussion_r3246158306
##########
common/src/main/java/org/apache/gravitino/credential/CredentialPropertyUtils.java:
##########
@@ -51,6 +51,24 @@ public class CredentialPropertyUtils {
private static final String GCS_OAUTH_2_TOKEN_EXPIRES_AT =
"gcs.oauth2.token-expires-at";
+ // Lance storage_options key constants
+ @VisibleForTesting static final String LANCE_S3_ACCESS_KEY_ID =
"aws_access_key_id";
Review Comment:
Iceberg and Lance could reuse the same constants. All of them are credential
properties. Just rename the variable name. It will be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
