sunyuhan1998 commented on code in PR #10895:
URL: https://github.com/apache/gravitino/pull/10895#discussion_r3247382898
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceTableOperations.java:
##########
@@ -90,16 +96,38 @@ public Response describeTable(
DescribeTableRequest request) {
try {
validateDescribeTableRequest(request);
+ boolean vendCredentials =
+ request.getVendCredentials() == null ||
Boolean.TRUE.equals(request.getVendCredentials());
Review Comment:
Based on the interface specification of `lance-namespace`, it only
stipulates that when the configuration **vend_credentials** is set to `true`,
the server must return vended credentials. If this attribute is not explicitly
specified, the server may determine the default behavior at its discretion;
refer to:
https://github.com/lance-format/lance-namespace/blob/81d3adf153aab117c43aabc474ce462831965e04/docs/src/spec.yaml#L2556-L2559
for details. However, looking at the current implementation of the Lance
client, it does not carry or specify the `vend_credentials` parameter by
default. This means the decision is delegated to the server implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
