sunyuhan1998 commented on code in PR #10895:
URL: https://github.com/apache/gravitino/pull/10895#discussion_r3246491055
##########
lance/lance-rest-server/src/main/java/org/apache/gravitino/lance/service/rest/LanceTableOperations.java:
##########
@@ -90,16 +96,38 @@ public Response describeTable(
DescribeTableRequest request) {
try {
validateDescribeTableRequest(request);
+ boolean vendCredentials =
+ request.getVendCredentials() == null ||
Boolean.TRUE.equals(request.getVendCredentials());
Review Comment:
The extra null check (`request.getVendCredentials() == null ||`) is
intentional — it defaults `vendCredentials` to `true` when not specified,
following the Lance official reference implementation(see
[`unwrap_or(true)`](https://github.com/lance-format/lance/blob/main/rust/lance-namespace-impls/src/dir.rs#L1280))where
`unwrap_or(true)` is used. That said, we are open to changing the default to
`false` if you think that is more appropriate. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
