lasdf1234 commented on code in PR #12132: URL: https://github.com/apache/gravitino/pull/12132#discussion_r3635970914
########## common/src/testFixtures/java/org/apache/gravitino/encryption/kms/FakeKmsClient.java: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.encryption.kms; + +import java.util.HashMap; +import java.util.Locale; +import java.util.Map; +import java.util.Optional; + +/** In-memory KMS client for contract and consumer tests. */ +public final class FakeKmsClient implements KmsClient { + + private final String api; + private final String source; + private final Map<String, KeyState> keys = new HashMap<>(); + + /** + * Creates an empty fake client. + * + * @param api canonical KMS API identifier accepted by the client + * @param source configured source accepted by the client + */ + public FakeKmsClient(String api, String source) { + if (api == null || api.trim().isEmpty()) { + throw new IllegalArgumentException("KMS API cannot be blank"); Review Comment: May be StringUtils is better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
