nevzheng commented on code in PR #12132: URL: https://github.com/apache/gravitino/pull/12132#discussion_r3639792727
########## api/src/main/java/org/apache/gravitino/encryption/kms/KmsReference.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.encryption.kms; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.google.common.base.Preconditions; +import java.util.Locale; +import java.util.Objects; +import javax.annotation.Nullable; +import org.apache.commons.lang3.StringUtils; +import org.apache.gravitino.annotation.DeveloperApi; + +/** + * Identifies a key owned by a configured KMS source. + * + * <p>Contains no credentials or key material. + */ +@DeveloperApi +public final class KmsReference { + + private final String api; + private final String source; + private final String keyId; + + /** + * Creates a structurally valid key reference without contacting the provider. + * + * @param api explicitly selected KMS API identifier + * @param source configured KMS client-instance name + * @param keyId provider-native key identifier + * @throws IllegalArgumentException if any argument is null or blank + */ + @JsonCreator + public KmsReference( + @JsonProperty("api") String api, + @JsonProperty("source") String source, + @JsonProperty("keyId") String keyId) { Review Comment: Done in 54adf1693. `KmsReference` is now an annotation-free API value, while `KmsReferenceDTO` in `common` owns the Jackson wire shape and bidirectional conversion. `testKmsReferenceDtoSerde` verifies the exact JSON shape, DTO round-trip, conversion back to the API value, and API identifier canonicalization. The complete API/common tests, Spotless checks, test-fixture packaging, and Javadocs pass. ########## common/src/testFixtures/java/org/apache/gravitino/encryption/kms/FakeKmsClient.java: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.encryption.kms; + +import java.util.HashMap; +import java.util.Locale; +import java.util.Map; +import java.util.Optional; + +/** In-memory KMS client for contract and consumer tests. */ +public final class FakeKmsClient implements KmsClient { + + private final String api; + private final String source; + private final Map<String, KeyState> keys = new HashMap<>(); + + /** + * Creates an empty fake client. + * + * @param api canonical KMS API identifier accepted by the client + * @param source configured source accepted by the client + */ + public FakeKmsClient(String api, String source) { + if (api == null || api.trim().isEmpty()) { + throw new IllegalArgumentException("KMS API cannot be blank"); Review Comment: Done in 54adf1693. The fake client now uses `StringUtils.isBlank(api)`, with constructor coverage for null, empty, and whitespace-only values. `commons-lang3` is scoped to the reusable test-fixtures implementation, and the complete common test suite passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
