nevzheng commented on PR #12132: URL: https://github.com/apache/gravitino/pull/12132#issuecomment-5060945654
@jerryshao @roryqi — the latest review updates are pushed in `54adf1693`: - separated the `KmsReference` API value from its Jackson wire DTO; - added exact DTO serialization, round-trip, conversion, and canonicalization coverage; and - adopted the requested `StringUtils.isBlank` validation in the fake provider fixture. The complete API/common tests, Spotless checks, fixture packaging, and Javadocs pass. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
