nevzheng commented on code in PR #12132: URL: https://github.com/apache/gravitino/pull/12132#discussion_r3646879520
########## api/src/main/java/org/apache/gravitino/encryption/kms/KmsApi.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.encryption.kms; + +import java.util.Arrays; +import java.util.Locale; +import java.util.stream.Collectors; +import org.apache.gravitino.annotation.DeveloperApi; + +/** The KMS product API that defines key identifier and operation semantics. */ +@DeveloperApi +public enum KmsApi { Review Comment: I reconsidered this and restored the string-backed `KmsApi` enum in 64c5bdc29. This is an intentional judgment call: Gravitino must prevalidate KMS API identifiers against the set it explicitly supports. A domain enum provides that guarantee and avoids a stringly typed contract where unsupported values fail only during runtime dispatch. Adding a new KMS API should be an explicit API change; the SPI remains the extension point for implementations of those approved APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
