nicknezis commented on a change in pull request #3779:
URL: https://github.com/apache/incubator-heron/pull/3779#discussion_r831761235
##########
File path: docker/scripts/compile-docker.sh
##########
@@ -36,13 +36,8 @@ dockerfile_path_for_platform() {
echo "$SCRATCH_DIR/compile/Dockerfile.$1"
}
-copy_bazel_rc_to() {
- cp $PROJECT_DIR/tools/docker/bazel.rc $1
-}
-
Review comment:
This was needed to limit CPU and memory for Bazel (and Java) when
running in a container. But with the newer JDK 11, the previous issues no
longer exist. Whenever I build, I usually disable the contents of this file.
This greatly speeds up the builds done in the container. Also it's one less
place to maintain any `.bazelrc` custom config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
