surahman commented on a change in pull request #3779:
URL: https://github.com/apache/incubator-heron/pull/3779#discussion_r832482308
##########
File path: scripts/get_all_heron_paths.sh
##########
@@ -21,8 +21,8 @@ set -eu
set +e
# Build everything
DIR=`dirname $0`
-source ${DIR}/detect_os_type.sh
Review comment:
This script is used also used in the following files and locations as
well:
https://github.com/apache/incubator-heron/blob/b12a3965f4acf1ac3f26c27ae4ead624afe706ce/scripts/run_integration_test.sh#L78
https://github.com/apache/incubator-heron/blob/b12a3965f4acf1ac3f26c27ae4ead624afe706ce/scripts/run_integration_topology_test.sh#L40
Given the OS flags can we drop/migrate usage in these scripts as well?
##########
File path: scripts/run_integration_test.sh
##########
@@ -76,8 +76,8 @@ set -e
# building tar packages
DIR=`dirname $0`
source ${DIR}/detect_os_type.sh
Review comment:
Can we drop this usage as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
