surahman commented on pull request #3779: URL: https://github.com/apache/incubator-heron/pull/3779#issuecomment-1075490662
Great work on this PR, there are some really important changes. I know some of these changes are cascading and build/require each other but it would be better to introduce them as multiple small changes. This way if there is an issue with some of the changes, we can revert the culprits without losing all changes. I would get @nwangtw to once over and approve the changes before merging. It looks good to me. I have a few comments/questions - none of which would hold anything up on my end. It would be nice if @joshfischer1108, or someone else with an Apple Silicone machine, could let us know if they are encountering any other build issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
