surahman commented on a change in pull request #3779:
URL: https://github.com/apache/incubator-heron/pull/3779#discussion_r832492842
##########
File path: scripts/travis/build.sh
##########
@@ -60,35 +60,28 @@ fi
set +x
-# Autodiscover the platform
-PLATFORM=$(discover_platform)
-echo "Using $PLATFORM platform"
-
# Run this manually, since if it fails when run
# as -workspace_status_command we don't get good output
./scripts/release/status.sh
-# append the bazel default bazelrc to travis/bazel.rc
-# for using rules provided by bazel
-# cat ~/.bazelrc >> tools/travis/bazel.rc
./bazel_configure.py
# build heron
T="heron build"
start_timer "$T"
${UTILS}/save-logs.py "heron_build.txt" bazel\
- --bazelrc=tools/travis/bazel.rc build --config=$PLATFORM heron/... \
+ build --config=stylecheck heron/... \
Review comment:
Not too sure about this, but I am wondering if it is strictly necessary
to run style checks on all the subsequent tests? Assuming this builds the
entire Heron package, it should be sufficient to run the test in one of builds?
##########
File path: scripts/run_integration_topology_test.sh
##########
@@ -38,8 +38,8 @@ set -e
# building tar packages
DIR=`dirname $0`
source ${DIR}/detect_os_type.sh
Review comment:
Can we drop this usage as well?
##########
File path: scripts/run_integration_test.sh
##########
@@ -76,8 +76,8 @@ set -e
# building tar packages
DIR=`dirname $0`
source ${DIR}/detect_os_type.sh
Review comment:
Can we migrate/drop this usage as well?
##########
File path: scripts/get_all_heron_paths.sh
##########
@@ -21,8 +21,8 @@ set -eu
set +e
# Build everything
DIR=`dirname $0`
-source ${DIR}/detect_os_type.sh
Review comment:
This script is used in the files below as well, can we drop/migrate
usage there as well? If so it would eliminate the usage of the script and we
could delete it.
https://github.com/apache/incubator-heron/blob/b12a3965f4acf1ac3f26c27ae4ead624afe706ce/scripts/run_integration_test.sh#L78
https://github.com/apache/incubator-heron/blob/b12a3965f4acf1ac3f26c27ae4ead624afe706ce/scripts/run_integration_topology_test.sh#L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
