nwangtw commented on a change in pull request #3142: Validate resource
constraint (RAM and CPU) in RoundRobinPacking
URL: https://github.com/apache/incubator-heron/pull/3142#discussion_r245051931
##########
File path:
heron/packing/src/java/org/apache/heron/packing/roundrobin/RoundRobinPacking.java
##########
@@ -367,16 +410,16 @@ private ByteAmount getContainerRamHint(Map<Integer,
List<InstanceId>> allocation
return TopologyUtils.getConfigWithDefault(
topologyConfig,
org.apache.heron.api.Config.TOPOLOGY_CONTAINER_RAM_REQUESTED,
- NOT_SPECIFIED_NUMBER_VALUE);
+ NOT_SPECIFIED_BYTE_AMOUNT);
}
/**
- * Check whether the PackingPlan generated is valid
+ * Check whether the PackingPlan configured each instance to have at least
minimum required RAM
Review comment:
There might be more checks in the function, like CPU and disk and maybe
others. I feel validatePackingPlan() makes more sense here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
