nwangtw commented on a change in pull request #3142: Validate resource
constraint (RAM and CPU) in RoundRobinPacking
URL: https://github.com/apache/incubator-heron/pull/3142#discussion_r245385589
##########
File path:
heron/packing/tests/java/org/apache/heron/packing/roundrobin/RoundRobinPackingTest.java
##########
@@ -255,6 +282,41 @@ public void testCompleteRamMapRequested() throws
Exception {
Assert.assertEquals(totalInstances,
packingPlanExplicitRamMap.getInstanceCount());
}
+ /**
+ * Test the scenario CPU map config is completely set
+ */
+ @Test
+ public void testCompleteCpuMapRequested() throws Exception {
Review comment:
Can we add these cases:
- container cpu is more than needed by instances.
- container cpu is less than needed by instances.
also, other processes in container could need a fixed amount of CPU as well.
So if container cpu == needed by instances, it might be better to return false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
