nwangtw commented on a change in pull request #3142: Validate resource 
constraint (RAM and CPU) in RoundRobinPacking
URL: https://github.com/apache/incubator-heron/pull/3142#discussion_r245384396
 
 

 ##########
 File path: 
heron/packing/tests/java/org/apache/heron/packing/roundrobin/RoundRobinPackingTest.java
 ##########
 @@ -158,8 +177,12 @@ public void testContainerRequestedResources() throws 
Exception {
       Assert.assertEquals(1, resources.size());
       int instancesCount = containerPlan.getInstances().size();
       Assert.assertEquals(containerRam
-          
.minus(RoundRobinPacking.DEFAULT_RAM_PADDING_PER_CONTAINER).divide(instancesCount),
+              
.minus(RoundRobinPacking.DEFAULT_RAM_PADDING_PER_CONTAINER).divide(instancesCount),
 
 Review comment:
   this indent change is needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to