nwangtw commented on a change in pull request #3142: Validate resource
constraint (RAM and CPU) in RoundRobinPacking
URL: https://github.com/apache/incubator-heron/pull/3142#discussion_r245383455
##########
File path:
heron/packing/src/java/org/apache/heron/packing/roundrobin/RoundRobinPacking.java
##########
@@ -288,7 +330,7 @@ private ByteAmount
getContainerRamPadding(List<TopologyAPI.Config.KeyValue> topo
}
for (int i = 1; i <= numContainer; ++i) {
- allocation.put(i, new ArrayList<InstanceId>());
+ allocation.put(i, new ArrayList<>());
Review comment:
this change seems to be unnecessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
