bvaradar commented on a change in pull request #673: Hudi-96: Command line
options instead of positional arguments
URL: https://github.com/apache/incubator-hudi/pull/673#discussion_r290047284
##########
File path:
hoodie-cli/src/main/java/com/uber/hoodie/cli/commands/RepairsCommand.java
##########
@@ -57,8 +57,14 @@ public String deduplicate(@CliOption(key = {
"sparkProperties"}, help = "Spark Properites File Path", mandatory =
true) final String sparkPropertiesPath)
throws Exception {
SparkLauncher sparkLauncher = SparkUtil.initLauncher(sparkPropertiesPath);
- sparkLauncher.addAppArgs(SparkMain.SparkCommand.DEDUPLICATE.toString(),
duplicatedPartitionPath, repairedOutputPath,
- HoodieCLI.tableMetadata.getBasePath());
+
+ SparkMain.HoodieDeduplicatePartitionCommandConfig config = new
SparkMain.HoodieDeduplicatePartitionCommandConfig();
Review comment:
Can you also move this config HoodieDeduplicatePartitionCommandConfig to
DedupeSparkJob and if possible, move DedupeSparkJob to hoodie-utilities from cli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
