bvaradar commented on a change in pull request #673: Hudi-96: Command line
options instead of positional arguments
URL: https://github.com/apache/incubator-hudi/pull/673#discussion_r290046007
##########
File path:
hoodie-cli/src/main/java/com/uber/hoodie/cli/commands/CommitsCommand.java
##########
@@ -131,8 +132,13 @@ public String rollbackCommit(@CliOption(key = {"commit"},
help = "Commit to roll
}
SparkLauncher sparkLauncher = SparkUtil.initLauncher(sparkPropertiesPath);
- sparkLauncher
- .addAppArgs(SparkMain.SparkCommand.ROLLBACK.toString(), commitTime,
HoodieCLI.tableMetadata.getBasePath());
+
+ SparkMain.HoodieRollbackCommandConfig config = new
SparkMain.HoodieRollbackCommandConfig();
Review comment:
To keep things consistent, Can you define a separate main class HudiRollback
similar to com.uber.hoodie.utilities.HoodieCompactor and define both config and
move the rollback calling logic from SparkMain to the new class ?
Rollback to savepoint should be handled in the same new class
com.uber.hoodie.utilities.HudiRollback
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
