bvaradar commented on a change in pull request #673: Hudi-96: Command line options instead of positional arguments URL: https://github.com/apache/incubator-hudi/pull/673#discussion_r291836694
########## File path: hoodie-common/src/main/java/com/uber/hoodie/config/AbstractCommandConfig.java ########## @@ -0,0 +1,123 @@ +/* Review comment: Didn't realize this is still in hoodie-common. Can you move this and InvalidCommandConfigException to hoodie-utilities. Only CLI related configs can inherit from this class. to keep it simple. This would mean that HiveSyncConfig changes can be reverted ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
