bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344430927
########## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ########## @@ -325,6 +326,31 @@ public static SparkConf registerClasses(SparkConf conf) { } } + /** + * Deletes a bunch of keys from the Hoodie table, at the supplied commitTime + */ + public JavaRDD<WriteStatus> delete(JavaRDD<HoodieKey> keys, final String commitTime) { Review comment: With new write APIs coming in, I think it would make sense to record the action (upsert/insert/bulkinsert/delete) corresponding to the write batch in HoodieCommitMetadata itself. This could be a separate newbie task in itself. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services