bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete
api to HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344432746
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -325,6 +326,31 @@ public static SparkConf registerClasses(SparkConf conf) {
}
}
+ /**
+ * Deletes a bunch of keys from the Hoodie table, at the supplied commitTime
+ */
+ public JavaRDD<WriteStatus> delete(JavaRDD<HoodieKey> keys, final String
commitTime) {
+ HoodieTable<T> table = getTableAndInitCtx();
+ try {
+ // De-dupe/merge if needed
+ JavaRDD<HoodieKey> dedupedKeys =
+ combineKeysOnCondition(config.shouldCombineBeforeUpsert(), keys,
config.getUpsertShuffleParallelism());
Review comment:
@bhasudha : We do support precombine for upsert, insert and bulkInsert
calls. For delete, it is merely just deduping keys - there isn't any custom
combine logic as the payload is not there. Yeah, I thought Its ok to have
similar semantics for deletes as other APIs just to be consistent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
