bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete
api to HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344430980
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -366,10 +392,19 @@ private void commitOnAutoCommit(String commitTime,
JavaRDD<WriteStatus> resultRD
private JavaRDD<HoodieRecord<T>> combineOnCondition(boolean condition,
JavaRDD<HoodieRecord<T>> records,
int parallelism) {
+ return condition ? deduplicateRecords(records, parallelism) : records;
+ }
+
+ private JavaRDD<HoodieKey> combineKeysOnCondition(boolean condition,
JavaRDD<HoodieKey> keys,
+ int parallelism) {
if (condition) {
- return deduplicateRecords(records, parallelism);
+ return deduplicateKeys(keys, parallelism);
}
- return records;
+ return keys;
+ }
+
+ private JavaRDD<HoodieRecord<T>>
generateHoodieRecordsToDeleteFromKeys(JavaRDD<HoodieKey> keys) {
Review comment:
Does this require separate function. Seems trivial ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
