bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete
api to HoodieWriteClient
URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344431628
##########
File path:
hudi-client/src/test/java/org/apache/hudi/TestHoodieClientOnCopyOnWriteStorage.java
##########
@@ -515,6 +516,161 @@ public void testSmallInsertHandlingForInserts() throws
Exception {
inserts1.size() + inserts2.size() + insert3.size());
}
+ /**
Review comment:
@nsivabalan : Can you see if you add additional test-block (for testing
deletes) to existing test like testUpsertsInternal ? Keeps test code
manageable, avoids duplicate test-setups and also can be used to test
diffferent combination (upsert/upsertPrepped followed by delete) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
