bvaradar commented on a change in pull request #1128: [HUDI-453] Fix throw
failed to archive commits error when writing data to MOR/COW table
URL: https://github.com/apache/incubator-hudi/pull/1128#discussion_r361833711
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -473,8 +473,8 @@ public void saveToCleanRequested(HoodieInstant instant,
Option<byte[]> content)
Preconditions.checkArgument(instant.getState().equals(State.REQUESTED));
// Write workload to auxiliary folder
createFileInAuxiliaryFolder(instant, content);
- // Plan is only stored in auxiliary folder
- createFileInMetaPath(instant.getFileName(), Option.empty(), false);
+ // Plan is stored in meta path
+ createFileInMetaPath(instant.getFileName(), content, false);
Review comment:
@lamber-ken : thanks for the change. This should fix the empty content for
clean requested but you still need the changes you did for commit and
delta-commit requested instants. Those are still empty files and we nee the
changes in HoodieCommitArchiveLog to handle it. Let me know if it makes sense ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
