lamber-ken commented on a change in pull request #1128: [HUDI-453] Fix throw
failed to archive commits error when writing data to MOR/COW table
URL: https://github.com/apache/incubator-hudi/pull/1128#discussion_r361847336
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -473,8 +473,8 @@ public void saveToCleanRequested(HoodieInstant instant,
Option<byte[]> content)
Preconditions.checkArgument(instant.getState().equals(State.REQUESTED));
// Write workload to auxiliary folder
createFileInAuxiliaryFolder(instant, content);
- // Plan is only stored in auxiliary folder
- createFileInMetaPath(instant.getFileName(), Option.empty(), false);
+ // Plan is stored in meta path
+ createFileInMetaPath(instant.getFileName(), content, false);
Review comment:
hi @bvaradar, `HoodieCommitArchiveLog#convertToAvroRecord` don't need to
handle commit and delta-commit empty files, because when reading these files,
`HoodieCommitMetadata#fromBytes` checks whether empty content or not, return a
new HoodieCommitMetadata instance when meets empty file.
BTW, from bellow structure, we can learn that creating a new
commit/delta-commit instant with empty content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
