bvaradar commented on a change in pull request #1128: [HUDI-453] Fix throw
failed to archive commits error when writing data to MOR/COW table
URL: https://github.com/apache/incubator-hudi/pull/1128#discussion_r361890138
##########
File path:
hudi-client/src/main/java/org/apache/hudi/io/HoodieCommitArchiveLog.java
##########
@@ -249,6 +249,13 @@ public void archive(List<HoodieInstant> instants) throws
HoodieCommitException {
LOG.info("Wrapper schema " + wrapperSchema.toString());
List<IndexedRecord> records = new ArrayList<>();
for (HoodieInstant hoodieInstant : instants) {
+
+ // filter empty instant, like *.commit.requested
+ byte[] instantDetails =
commitTimeline.getInstantDetails(hoodieInstant).get();
+ if (instantDetails == null || instantDetails.length == 0) {
+ continue;
+ }
+
Review comment:
@lamber-ken : This is not directly related but I created
https://jira.apache.org/jira/browse/HUDI-483 for tracking this unit test issue.
Please assign it to yourself if you are planning to work on this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
