bvaradar commented on a change in pull request #1157: [HUDI-332]Add operation
type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#discussion_r362130449
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieCommitMetadata.java
##########
@@ -106,6 +150,14 @@ public void setCompacted(Boolean compacted) {
return filePaths;
}
+ public void setOperateType(Type type) {
Review comment:
We also need to add the enum type to the avro schema
hudi-common/src/main/avro/HoodieCommitMetadata.avsc
For archiving, we use the avro class
org.apache.hudi.avro.model.HoodieCommitMetadata instead of
org.apache.hudi.common.model.HoodieCommitMetadata
HoodieCommitArchiveLog.commitMetadataConverter needs to change to copy the
operation types to avro objects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services