bvaradar commented on a change in pull request #1157: [HUDI-332]Add operation
type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#discussion_r362728805
##########
File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
##########
@@ -510,21 +515,21 @@ private Partitioner getPartitioner(HoodieTable table,
boolean isUpsert, Workload
/**
* Commit changes performed at the given commitTime marker.
*/
- public boolean commit(String commitTime, JavaRDD<WriteStatus> writeStatuses)
{
- return commit(commitTime, writeStatuses, Option.empty());
+ public boolean commit(String commitTime, JavaRDD<WriteStatus> writeStatuses,
WriteOperationType operationType) {
Review comment:
As only one hudi write operation is outstanding at a time, can you cache the
last operation type in instance variables within HoodieWriteClient object so
that users don't need to explicitly pass them in this commit() call
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
